Improve Tag Selectors#224
Merged
Merged
Conversation
Member
|
I like the last options where everything uses the TagSelector, then it's always in sync. |
jmattheis
reviewed
Nov 30, 2025
Co-authored-by: Jannis Mattheis <contact@jmattheis.de>
jmattheis
reviewed
Dec 8, 2025
jmattheis
approved these changes
Dec 14, 2025
jmattheis
left a comment
jmattheis
left a comment
Member
There was a problem hiding this comment.
With the adjusted addValues function this looks much better, thanks for implementing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #215, i am making another PR for improving TagSelector.
Here i want to expand TagSelector capabilities to allow for filters based on tags and values and standardize chip margins so new filter selectors won't look out of place.
I have a few variants on how to change the margins:
it looks pretty good in the dashboard, but a bit cramped in the list view
I think that looks better
Also i made a variant, where i replaced TagKeySelector with TagSelector
I am presenting all of this before pushing anything, so you can choose the best one and give some feedback