Skip to content

Fix NamedType error in tests #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

mschwager
Copy link
Member

Fixes:

--- expected
+++ actual
@@ -1,3 +1,5 @@
+WARNING: type 'NamedType' has been deprecated and may be removed in future (MissingMinVersionTLS.ql:97,12-21)
+WARNING: type 'NamedType' has been deprecated and may be removed in future (MissingMinVersionTLS.ql:102,12-21)
 | MissingMinVersionTLS.go:25:14:25:25 | struct literal | TLS.Config.MinVersion is never set for variable $@  | MissingMinVersionTLS.go:25:3:25:8 | config | config |
 | MissingMinVersionTLS.go:35:14:37:3 | struct literal | TLS.Config.MinVersion is never set for variable $@  | MissingMinVersionTLS.go:35:3:35:8 | config | config |
 | MissingMinVersionTLS.go:50:13:50:24 | struct literal | TLS.Config.MinVersion is never set for variable $@  | MissingMinVersionTLS.go:50:3:50:8 | config | config |

https://codeql.github.com/docs/codeql-overview/codeql-changelog/codeql-cli-2.20.5/#id9

@@ -14,6 +14,6 @@ jobs:
uses: github/codeql-action/init@v3
- name: Run tests
run: |
${{ steps.init.outputs.codeql-path }} test run ./cpp/test/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why cpp and go tests are removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to fix the test failures in main, but I've been unable to reproduce locally. I removed the cpp and go tests here to limit the number of tests being run in CI, just for debugging.

It's been a while, but my suspicion was that there is some dependency discrepancy between CI and local dev. Maybe some caching layer is affecting something somewhere. Anyway, I could never fully understand why this single Recursion.ql test fails in CI, but I'm unable to reproduce locally. I'll probably just close this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will give it a try later too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants