Repository navigation
Conversation
beecbef to
e8681cb
Compare
4be0392 to
049e86e
Compare
|
#2179 is merged. (Thanks, BTW. 🙏) When you get a chance, could you please update this PR? |
049e86e to
391feaf
Compare
|
Updated. |
|
I like the But could you please make changing the libraries directory layout its own PR? Also, I don't think we discussed changing the drivers directory layout. Why is that needed? |
|
Thanks! How about narrowing this PR to The driver layout change was meant to avoid different Dylint versions or development checkouts replacing each other’s cached drivers. It isn’t required for Would that scope work for you? AI assistant on behalf of @dblock. |
Yes to all. In a previous discussion, I think you proposed (or I assumed) we would use: I like that organization. I don't see an obvious reason to have an additional Deprecating but continuing to honor Let's please continue to leave Thank you very much for working on this. |
Let's decide this first. I prefer Now that I think of it, maybe the cache should live in |
I think I'm not following. For myself, I wouldn't want those in But maybe you're thinking about this differently? |
|
For me these are caches that don't have to survive a reboot because they tend to accumulate large and I do not do dylint development work that often. I suppose there's an even better location for that case, the OS's standard cache location: I am good with introducing |
391feaf to
b5d1515
Compare
|
@smoelius Updated. Now the next step could be:
|
smoelius
left a comment
There was a problem hiding this comment.
I'd like to give this another pass, but please squash your changes into one commit in case everything looks good-to-go.
Thanks again for working on this.
| let dylint_home = dylint_home()?; | ||
| let dylint_drivers = dylint_home.join("drivers"); |
There was a problem hiding this comment.
Let's please have it that if DYLINT_HOME is unset, ~/.dylint_drivers is still created by default.
I would like to treat the ~/.dylint-as-default switch as a breaking change.
| dylint_home_from(None).unwrap(), | ||
| home_dir().unwrap().join(".dylint") |
There was a problem hiding this comment.
Nit. In the tests you added, please swap the order of the assert_eq! arguments so that they have expected-actual ordering.
b5d1515 to
3882628
Compare
Introduce `DYLINT_HOME`, an absolute path that, when set, stores rustc drivers in `$DYLINT_HOME/drivers/<toolchain>/`. When it is unset, drivers remain in `~/.dylint_drivers`, so the default is unchanged. `DYLINT_DRIVER_PATH` still takes precedence for drivers. `DYLINT_LIBRARIES_DIR` remains unset by default; documentation suggests `~/.dylint/libraries` as a location for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Gr21iB7eqGFMpDHcr3JJE
3882628 to
8b36755
Compare
|
Thanks! Done: AI assistant on behalf of @dblock. |
Narrowed per review discussion: this PR only introduces an opt-in
DYLINT_HOMEfor drivers. Defaults are unchanged; switching the default to~/.dylintis left for a future breaking release.Changes
DYLINT_HOME, an absolute path. When set, Dylint stores rustc drivers in$DYLINT_HOME/drivers/<toolchain>/. Empty or relative values are rejected.DYLINT_HOMEis unset, drivers remain in~/.dylint_drivers/<toolchain>/as before.DYLINT_DRIVER_PATHis unchanged and still takes precedence overDYLINT_HOMEfor drivers.DYLINT_LIBRARIES_DIRunset by default; the README and CLI help suggest~/.dylint/librariesas a location for it.Validation
On macOS (Apple Silicon):
~/.dylint_driverswithoutDYLINT_HOME,$DYLINT_HOME/driverswith it, and empty or relativeDYLINT_HOMErejected.dylint_driver_path(still works and takes precedence overDYLINT_HOME) anddylint_home(drivers built under a not-yet-existingDYLINT_HOMEcontaining a space, withREADME.txt, and runnable directly).-D warnings) ondylint,cargo-dylint, anddylint_internal; the workspace self-lint (ci::lint);fmt,usage, README synchronization, and Markdown checks.Linux and Windows are left to CI.
AI disclosure: This PR was authored by an AI assistant (Claude) on behalf of @dblock.
🤖 Generated with Claude Code
https://claude.ai/code/session_011Gr21iB7eqGFMpDHcr3JJE