Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create OneTrust types #205

Merged
merged 14 commits into from
Jan 13, 2025
Merged

create OneTrust types #205

merged 14 commits into from
Jan 13, 2025

Conversation

abrantesarthur
Copy link
Member

@abrantesarthur abrantesarthur commented Jan 13, 2025 •
edited
Loading

  • create types useful when interacting with the OneTrust APIs, creating OneTrust assessment CSV files, and importing these files into Transcend.

Related Issues

@height Height
Copy link

height bot commented Jan 13, 2025 •
edited
Loading

This pull request has been linked to and will mark 1 task as "Pending Deploy" when merged:

💡Tip: You can link multiple Height tasks to a pull request.

@abrantesarthur abrantesarthur changed the title create oneTrust assessment types create OneTrust types Jan 13, 2025
anotherminh
anotherminh approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@anotherminh anotherminh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

‼️

@abrantesarthur abrantesarthur merged commit ad48a42 into main Jan 13, 2025
10 checks passed
michaelfarrell76
michaelfarrell76 reviewed Jan 13, 2025
View reviewed changes
src/oneTrust/endpoints/getAssessment.ts
/** Type override */
export type OneTrustApprover = t.TypeOf<typeof OneTrustApprover>;

export const OneTrustAssessmentStatus = t.union([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit for next time: would define this as an enum then use valuesOf(EnumName) to create the codec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfarrell76 michaelfarrell76 michaelfarrell76 left review comments

@anotherminh anotherminh anotherminh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abrantesarthur @michaelfarrell76 @anotherminh