fix(privacy-types): bundle CJS deps to fix ESM resolution error#67
fix(privacy-types): bundle CJS deps to fix ESM resolution error#67michaelfarrell76 wants to merge 3 commits into
Conversation
type-utils and internationalization are CJS packages without an "exports" field, so Node.js ESM resolution fails when privacy-types (an ESM package) re-exports them as bare specifiers. Bundle them into the output instead and move to devDependencies.
@transcend-io/cli
@transcend-io/privacy-types
@transcend-io/sdk
@transcend-io/utils
commit: |
|
@michaelfarrell76 any chance we can publish ESM versions for those instead? I imagine this will cause big bundle growth and may make it to frontend JS bundles |
|
@bencmbrook that seems fine but i dont know how to update those to do that, do you? |
Yeah I can help tomorrow |
|
@michaelfarrell76 transcend-io/internationalization#31 and transcend-io/type-utils#48 separately, might make sense to port these over to this repo |
|
@bencmbrook ya no problem doing that! |
|
@bencmbrook whats next step here? want me to take over? |
|
Yes please—I think you can just close this PR and then bump the versions of these two packages and that should solve the ESM resolution problem (now it's all ESM!) |
|
@bencmbrook sg, should we also move those in here or you dont think so? |
I don't feel strongly. It's probably easier to maintain if they're in here |
type-utils and internationalization are CJS packages without an "exports" field, so Node.js ESM resolution fails when privacy-types (an ESM package) re-exports them as bare specifiers. Bundle them into the output instead and move to devDependencies.