Skip to content

TX-16723: Update template on parser - STRUCTURED JSON #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
foteinigk merged 2 commits into from
Dec 1, 2025
Merged

TX-16723: Update template on parser - STRUCTURED JSON #379

foteinigk merged 2 commits into from
Dec 1, 2025

Conversation

@foteinigk
Copy link
Contributor

@foteinigk foteinigk commented Nov 27, 2025 •
edited
Loading

Problem and/or solution

  • Implement add/remove strings functionality for structured json

How to test

Reviewer checklist

Code:

  • Change is covered by unit-tests
  • Code is well documented, well styled and is following best practices
  • Performance issues have been taken under consideration
  • Errors and other edge-cases are handled properly

PR:

  • Problem and/or solution are well-explained
  • Commits have been squashed so that each one has a clear purpose
  • Commits have a proper commit message according to TEM

@foteinigk foteinigk changed the base branch from devel to TX-16613 November 27, 2025 10:16
mvakalo
mvakalo reviewed Nov 28, 2025
View reviewed changes
Copy link

@mvakalo mvakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 🚀 Some small comments / questions!

mvakalo
mvakalo approved these changes Dec 1, 2025
View reviewed changes
Copy link

@mvakalo mvakalo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Feel free to rebase when the time comes :)

@foteinigk foteinigk merged commit 29ce4cc into TX-16613 Dec 1, 2025
2 checks passed
@foteinigk foteinigk deleted the TX-16613_2 branch December 1, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mvakalo mvakalo mvakalo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@foteinigk @mvakalo