Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

Better style encapsulation#18

Draft
DaniGuardiola wants to merge 1 commit into
transitive-bullshit:masterfrom
DaniGuardiola:style-encapsulation
Draft

Better style encapsulation#18
DaniGuardiola wants to merge 1 commit into
transitive-bullshit:masterfrom
DaniGuardiola:style-encapsulation

Conversation

@DaniGuardiola

@DaniGuardiola DaniGuardiola commented Mar 31, 2021

Copy link
Copy Markdown

Done:

Untested, pls help me out @transitive-bullshit, check your DMs :)

Other ideas:

  • Make parent class more specific, for example: static-tweet => __static_tweet__
  • Change selectors to depend on the parent class, for example: .static-tweet-anchor => .static-tweet .anchor
  • CSS modules? (I don't really think it adds much value but it's an option)

@vercel

vercel Bot commented Mar 31, 2021

Copy link
Copy Markdown

Someone is attempting to deploy a commit to a Personal Account owned by @transitive-bullshit on Vercel.

@transitive-bullshit first needs to authorize it.

@transitive-bullshit

Copy link
Copy Markdown
Owner

@DaniGuardiola I didn't now about the all: initial trick — this is awesome.

I honestly think it's good enough assuming it works. Let's keep it simple for now.

Let me know when you think it's good to merge.

Thanks!

@transitive-bullshit

Copy link
Copy Markdown
Owner

I will take another look at this after we find a fix for #23 which is currently blocking react-static-tweets from being used with webpack 5.

@DaniGuardiola

Copy link
Copy Markdown
Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS styles being overridden

2 participants