Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use create-dmg to create a custom macOS disk image #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sweetppro
Copy link

Fixes transmission/transmission#4062
Im not sure if this is the correct place to customize the release .dmg, but it was the only obvious location...
Also not sure on how we prepare semantic versioning...
@ckerr @livings124 @mikedld

I have a placeholder custom background, which is easy enough to replace.
for future reference, the dmg_background.png file is 1000px * 620px (144dpi)
Screenshot 2022-11-28 at 3 29 53 pm

@ckerr ckerr requested a review from mikedld November 28, 2022 06:50
@livings124
Copy link
Member

This does look really nice but I'm hesitant to clone a third-party repo and then run a command from that in our release scripts

@sweetppro
Copy link
Author

This does look really nice but I'm hesitant to clone a third-party repo and then run a command from that in our release scripts

@livings124 that's a good point,
how about we maintain a fork of the repo, and link to our own fork.
then we can at least verify the security of any updates to the repo before we incorporate into the release script.

@sweetppro
Copy link
Author

create-dmg has an MIT license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] Use Drag to Install idiom in published DMG releases
2 participants