Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [ -z $var clauses without quotes #1162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

native-api
Copy link
Contributor

@native-api native-api commented Feb 7, 2020

@ericzolf
Copy link

ericzolf commented Feb 7, 2020

Looks good to me (I would suggest to have all variables in the form ${VAR} with curly brackets but that's only cosmetic and can wait). Can I test the patch in my pipeline or do I have to wait for merging or releasing?

ericzolf added a commit to rdiff-backup/rdiff-backup that referenced this pull request Feb 7, 2020
Only tags really looking like release versions are deployed to PyPI
and Windows wheels aren't deployed until travis-ci/dpl#1161 and
travis-ci/dpl#1162 are fixed.
ericzolf added a commit to rdiff-backup/rdiff-backup that referenced this pull request Feb 9, 2020
* Replace Windows bdist through bdist_wheel for Travis - The bdist output is rather useless for PyPI whereas a Windows wheel could be uploaded.
* Add deployment to pypi and pypi test for sdist and bdist_wheel
* Temporarily remove the Windows bdist_wheel deployment and filter tag
* Only tags really looking like release versions according to PEP440 are deployed to PyPI
* Windows wheels aren't deployed until travis-ci/dpl#1161 and travis-ci/dpl#1162 are fixed.
DEV: automate via Travis deployment pipeline release to PyPI and Test PyPI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants