This repository was archived by the owner on May 10, 2018. It is now read-only.
Config should raise an error if both file and env configs are available #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use file configs for some apps and ENV config for the others. When both configs are available (for example because someone accidentally set an ENV config where file config is already set), Travis.config will silently prefer ENV over file config. This commit raises an error in such situation
Contributor
|
I'm a bit torn on this. It's a good idea to handle this situation better, but should we maybe focus on getting stuff out of config files and into environment variables? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use file configs for some apps and ENV config for the others. When
both configs are available (for example because someone accidentally set
an ENV config where file config is already set), Travis.config will
silently prefer ENV over file config.
I have tested this on staging and it raises on such situation properly.