Use new reserved words API to improve error recovery #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of Tree-sitter's upcoming "reserved words" feature in order to provide better error recovery in many common cases.
For example, the following code contains an error on line 2.
Previously, the parser would correctly allow the word
if
to be used as a property name on lines 1 and 4, but it would incorrectly allow the wordif
on line 3, which would prevent it from finding a good error recovery for the incomplete code on line 2.Old Parse Tree - It would interpret the word
if
as an identifier, preventing it from correctly recognizing theif_statement
below the error:New Parse Tree - On this branch, the
if_statement
is still parsed correctly, despite the error on the preceding line.