Open
Conversation
Kwandes
approved these changes
Oct 30, 2022
| String subject = "Your Treecreate order is waiting for your payment!"; | ||
| Context context = new Context(new Locale("da")); | ||
| context.setVariable("paymentLink", quickpayService.getPaymentLink(order.getPaymentId()).getUrl()); | ||
| System.out.println(quickpayService.getPaymentLink(order.getPaymentId())); |
Member
There was a problem hiding this comment.
Don't use normal console logs for this, use the Logger
But this log is redundant anyway since the ordersService already logs this, so it can be removed
Suggested change
| System.out.println(quickpayService.getPaymentLink(order.getPaymentId())); |
Teodor25
reviewed
Oct 30, 2022
apps/api/src/main/resources/data.sql
Outdated
| , 'ac86995f-60ae-4520-a434-c8abc98980b9' AS user_id | ||
| , 'c0a80121-7e81-1c3e-817e-82cc11180004' AS billing_info_contact_info_id | ||
| , 'c0a80121-7e81-1c3e-817e-82cc11180005' AS contact_info_contact_info_id | ||
| , false AS paymentReminderSent |
Contributor
There was a problem hiding this comment.
This should probably follow the naming convention for the database: payment_reminder_sent
Tho, if calli approves of it as it is, it's fine. But check with her.
Member
There was a problem hiding this comment.
It works either way, but might as well make it match the rest of the data
If it doesn't work after changing it to payment_reminder_sent then leave it as is @Sintry1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request closes:
✔️ Closes Jira Issue: TC-274
Which service(s) does this issue affect:
Types of changes
Documentation Updates
Testing checklist
Browser compatibility - [Frontend only]
What changes have been done within this issue?
Scheduled a method to send a payment reminder email to every unpaid order > 5 minutes old
How should this be manually tested?
(cron = "* 1 * * *?")to(cron = "1 * * * * ? ")to enable the scheduling every minuteScreenshots or example usage