Fix bug calculating days in duration #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Just pushed 9ff7605 which adds a broken test for a different (but likely related) bug. Still diagnosing. |
Contributor
Author
|
It was the same bug but in the opposite direction when adding durations. |
Contributor
Author
|
I just realized that only commented about adding broken tests but never stated that I actually fixed the problem. This has been ready to merge for months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was manifest under the following conditions:
It used the wrong month's days when calculating the overflow for the month. As you can see below I just needed to calculate the days after the overflow of the month was performed instead of before.