Swap the semantics of .size and .length #24
Closed
+84
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevnorris
pushed a commit
that referenced
this pull request
Jul 12, 2016
* Switch this.size and this.length to match Array semantics. * Update README with swapped size and length. PR-URL: #24 Reviewed-by: Trevor Norris <[email protected]>
|
Excuse my tardiness. This got lost in my box. Squashed and landed this as 4919c48. Released and npm published v2.0.0. Thanks much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for #23. It switches the meanings of
.size(now: number of allocated array elements) and.length(now: number of elements the array actually contains).Considerations: Despite bringing the API of CBuffer into closer alignment with
Array, this breaks the previous API, and as such would need a new major release.