xmtp quick actions #245
Merged
xmtp quick actions #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishboy
reviewed
Jul 9, 2025
| /** | ||
| * Individual action definition | ||
| */ | ||
| export type Action = { |
Collaborator
There was a problem hiding this comment.
rename to XmtpAction. It might be confusing to users with Action from eliza
hishboy
reviewed
Jul 9, 2025
| * Agents use this to present interactive button options to users | ||
| */ | ||
|
|
||
| export const ActionsContentSchema = z.object({ |
hishboy
reviewed
Jul 9, 2025
Comment on lines
+47
to
+53
| z.object({ | ||
| id: z.string(), | ||
| label: z.string(), | ||
| imageUrl: z.string().url().optional(), | ||
| style: z.enum(['primary', 'secondary', 'danger']).optional(), | ||
| expiresAt: z.string().datetime().optional() | ||
| }) |
Collaborator
There was a problem hiding this comment.
why not create a schema and infer the type on line 22 from it
Collaborator
There was a problem hiding this comment.
also use nullish for everything
hishboy
reviewed
Jul 9, 2025
Comment on lines
+112
to
+161
| if (!content.id || typeof content.id !== 'string') { | ||
| throw new Error('Actions.id is required and must be a string') | ||
| } | ||
|
|
||
| if (!content.description || typeof content.description !== 'string') { | ||
| throw new Error('Actions.description is required and must be a string') | ||
| } | ||
|
|
||
| if (!Array.isArray(content.actions) || content.actions.length === 0) { | ||
| throw new Error('Actions.actions is required and must be a non-empty array') | ||
| } | ||
|
|
||
| if (content.actions.length > 10) { | ||
| throw new Error('Actions.actions cannot exceed 10 actions for UX reasons') | ||
| } | ||
|
|
||
| // Validate each action | ||
| content.actions.forEach((action, index) => { | ||
| if (!action.id || typeof action.id !== 'string') { | ||
| throw new Error(`Action[${index}].id is required and must be a string`) | ||
| } | ||
|
|
||
| if (!action.label || typeof action.label !== 'string') { | ||
| throw new Error(`Action[${index}].label is required and must be a string`) | ||
| } | ||
|
|
||
| if (action.label.length > 50) { | ||
| throw new Error(`Action[${index}].label cannot exceed 50 characters`) | ||
| } | ||
|
|
||
| if (action.style && !['primary', 'secondary', 'danger'].includes(action.style)) { | ||
| throw new Error(`Action[${index}].style must be one of: primary, secondary, danger`) | ||
| } | ||
|
|
||
| if (action.expiresAt && !this.isValidISO8601(action.expiresAt)) { | ||
| throw new Error(`Action[${index}].expiresAt must be a valid ISO-8601 timestamp`) | ||
| } | ||
| }) | ||
|
|
||
| // Check for duplicate action IDs | ||
| const actionIds = content.actions.map((action) => action.id) | ||
| const uniqueActionIds = new Set(actionIds) | ||
| if (actionIds.length !== uniqueActionIds.size) { | ||
| throw new Error('Action.id values must be unique within Actions.actions array') | ||
| } | ||
|
|
||
| if (content.expiresAt && !this.isValidISO8601(content.expiresAt)) { | ||
| throw new Error('Actions.expiresAt must be a valid ISO-8601 timestamp') | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
why aren't we validating with zod?
Contributor
Author
There was a problem hiding this comment.
this is their code actually, so i didnt mess with it, its their library sort of, just copy pasted here
hishboy
reviewed
Jul 9, 2025
| * Content Type ID for Intent messages | ||
| * Following XIP-67 specification for inline actions | ||
| */ | ||
| export const ContentTypeIntent = new ContentTypeId({ |
hishboy
reviewed
Jul 9, 2025
| * Intent content structure | ||
| * Users express their selection by sending Intent messages when they tap action buttons | ||
| */ | ||
| export const IntentContentSchema = z.object({ |
hishboy
reviewed
Jul 9, 2025
| /** | ||
| * Validates Intent content according to XIP-67 specification | ||
| */ | ||
| private validateContent(content: IntentContent): void { |
Collaborator
There was a problem hiding this comment.
prefix this entire file with Xmtp
hishboy
approved these changes
Jul 9, 2025
Collaborator
hishboy
left a comment
hishboy
left a comment
There was a problem hiding this comment.
LGTM but please address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.