Dlopen apparmor #1140

bjorn3 · 2025-05-23T12:52:38Z

This still needs a test that LD_LIBRARY_PATH can't be used to load arbitrary code into the sudo process.

src/apparmor.rs

squell

I ran the MSRV-related changes and changing of the transmute-handling by Bjorn.

bjorn3 force-pushed the dlopen_apparmor branch 5 times, most recently from ba8a4f2 to 9d692aa Compare June 4, 2025 13:49

bjorn3 marked this pull request as ready for review June 4, 2025 13:51

bjorn3 requested a review from squell June 4, 2025 13:51

bjorn3 added 4 commits June 4, 2025 16:18

Move apparmor::sys into the main apparmor module

407409f

Improve import organization in apparmor.rs

6293973

Dlopen apparmor

b2131ff

Add test that LD_LIBRARY_PATH doesn't have any effect

e47d13f

bjorn3 force-pushed the dlopen_apparmor branch from 9d692aa to e47d13f Compare June 4, 2025 14:18

squell reviewed Jun 11, 2025

View reviewed changes

src/apparmor.rs Outdated Show resolved Hide resolved

squell added 2 commits June 11, 2025 14:28

address academic concerns with transmuting a void ptr to Option<fn()>

dc46a24

make code adhere to MSRV

e2d0395

squell approved these changes Jun 11, 2025

View reviewed changes

squell enabled auto-merge June 11, 2025 12:32

squell merged commit 9fd0f9c into trifectatechfoundation:main Jun 11, 2025
15 checks passed

bjorn3 deleted the dlopen_apparmor branch June 11, 2025 13:31

Provide feedback