Add sorting for clusters and query history page columns #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI build seemed to have failed with an unrelated error - |
|
Could you add screenshots to PR description when you modify UI code? |
Sure, done |
RoeyoOgen
reviewed
Sep 2, 2025
| return a.routingGroup.localeCompare(b.routingGroup); | ||
| }} | ||
| filters={ | ||
| [...new Set(backendData?.map(b => b.routingGroup))] |
There was a problem hiding this comment.
if backendData is undefined this may become new Set([undefined]), perhaps default to empty array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added sort options for clusters based on name, queued query count and running query count.
Added filter option for routingGroup and sort options for routignGroup and submission time in query history page.
Additional context and related issues
Clusters page header [3 new sort icons on Name, Queued, Running]:
History Page [Sort and Filter option on RoutingGroup] -
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( X) Release notes are required, with the following suggested text: