Test ANALYZE in BaseIcebergConnectorSmokeTest #27322
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
| String tableName = "test_analyze_" + randomNameSuffix(); | ||
|
|
||
| try { | ||
| assertUpdate("CREATE TABLE " + tableName + " AS SELECT * FROM nation", 25); |
There was a problem hiding this comment.
We should verify the collected NDV by the following ANALYZE. Could you use a session disabling collect_extended_statistics_on_write property?
There was a problem hiding this comment.
Out of curiousity how do you debug and I was wondering if I should insert values into the table before I use analyze to make sure the ndv was gathered?
There was a problem hiding this comment.
assertUpdate can accept the session property, so you can control the behavior
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Added BaseConnectorSmokeTest for Analyze to test different catalogs
Could you change both PR and commit title to "Test ANALYZE in BaseIcebergConnectorSmokeTest"?
There was a problem hiding this comment.
I changed the title and I am looking into how to change the commit title
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
WillPelech
changed the title
|
Hi I submitted the CLA around 5 days ago I was wondering how long it takes to get approved? |
3 participants
Description
This PR adds a test case to BaseConnectorSmokeTest testing that analyze works correctly if the connector supports the operation. If the test fails then it is because of lack of support so the test will then check that the test is indeed true for the underlying connector.
Fixes #27273
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: