docs(elasticsearch): update example timestamp #27323
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the example timestamp to a more current date in the Elasticsearch connector documentation.
Contributor
|
ah, looks like Google treats that page as the creation or supported start date 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the example timestamp in the doc to a more current date in the Elasticsearch connector documentation.
Additional context and related issues
This sounds like a weird PR, but a coworker noticed that Google was assuming the doc was created in 1987 (thanks @skedida!), maybe because it is a too specific timestamp in a structured format:
To avoid that quirk, I'm bumping the timestamp in the example to a more reasonable one this year (unaware if there's any reason to keep it in 1987).
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: