Improve RepeatFunction #27369
Merged
Improve RepeatFunction #27369
+30
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation is simplified by using RunLengthEncodedBlock
raunaqmorarka
force-pushed
the
repeat-func
branch
2 times, most recently
from
b18e93f to
e0cdfa6
Compare
wendigo
approved these changes
Nov 19, 2025
chenjian2664
approved these changes
Nov 19, 2025
pettyjamesm
reviewed
Nov 19, 2025
core/trino-main/src/main/java/io/trino/operator/scalar/RepeatFunction.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/RepeatFunction.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
repeat-func
branch
from
e0cdfa6 to
26e2b0d
Compare
pettyjamesm
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve performance of RepeatFunction by using RunLengthEncodedBlock directly
instead of going through BlockBuilder
Expand the max size limits on the function
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: