Repository navigation
Skip coarse delete file validation for Iceberg v3 writes - #30860
Closed
raunaqmorarka wants to merge 1 commit into
Closed
raunaqmorarka wants to merge 1 commit into
raunaqmorarka wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Format version 3 rejects concurrently added deletion vectors per referenced data file, so the table-wide check only rejects updates that do not conflict.
raunaqmorarka
force-pushed
the
iceberg-v3-dv-commit-conflicts
branch
from
August 21, 2026 15:38
e495f4a to
bcfb259
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For UPDATE and MERGE on Iceberg format version 3 tables, skip
validateNoConflictingDeleteFileswhen the table has no equality deletes. Iceberg already rejects concurrently added deletion vectors per referenced data file, so the coarse validation only adds false conflicts between writes that touch disjoint data files. The validation is kept when the table may contain equality deletes, since those are not covered by the per-file check.Additional context and related issues
The equality delete check reads the latest table snapshot summary, so equality deletes committed after that read and before the write commits are not detected. Concurrent DV commits for the same data file still conflict; apache/iceberg#17754 proposes merging them for pure delete commits.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: