Skip to content

Skip coarse delete file validation for Iceberg v3 writes - #30860

Closed
raunaqmorarka wants to merge 1 commit into
trinodb:masterfrom
raunaqmorarka:iceberg-v3-dv-commit-conflicts
Closed

raunaqmorarka wants to merge 1 commit into
trinodb:masterfrom
raunaqmorarka:iceberg-v3-dv-commit-conflicts

Conversation

@raunaqmorarka

Copy link
Copy Markdown
Member

Description

For UPDATE and MERGE on Iceberg format version 3 tables, skip validateNoConflictingDeleteFiles when the table has no equality deletes. Iceberg already rejects concurrently added deletion vectors per referenced data file, so the coarse validation only adds false conflicts between writes that touch disjoint data files. The validation is kept when the table may contain equality deletes, since those are not covered by the per-file check.

Additional context and related issues

The equality delete check reads the latest table snapshot summary, so equality deletes committed after that read and before the write commits are not detected. Concurrent DV commits for the same data file still conflict; apache/iceberg#17754 proposes merging them for pure delete commits.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Iceberg
* Reduce commit conflicts for concurrent `UPDATE` and `MERGE` on tables with format version 3. ({issue}`issuenumber`)

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@github-actions github-actions Bot added iceberg Iceberg connector cla-signed labels Aug 21, 2026
Format version 3 rejects concurrently added deletion vectors per referenced
data file, so the table-wide check only rejects updates that do not conflict.
@raunaqmorarka
raunaqmorarka force-pushed the iceberg-v3-dv-commit-conflicts branch from e495f4a to bcfb259 Compare August 21, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed iceberg Iceberg connector

Development

Successfully merging this pull request may close these issues.

1 participant