Skip to content

Translate es strings - #1911

Merged
CiaranGruber merged 2 commits into
tristinbaker:mainfrom
jmmartinell:translate-es-items-resto2-20260925002138
Sep 25, 2026
Merged

CiaranGruber merged 2 commits into
tristinbaker:mainfrom
jmmartinell:translate-es-items-resto2-20260925002138

Conversation

@jmmartinell

Copy link
Copy Markdown
Contributor

Before submitting

  • I have pulled and merged the latest changes from the repository

Language(s)

Spanish — both values-es (generic) and values-es-rES (Spain)

Summary

Remaining item families 2: special rings (wealth/seers/suffering), rock golem, runecrafting guild capes and leftover specials, in strings_items.xml.

Detailed changes

File Lines
values-es/strings_items.xml 60
values-es-rES/strings_items.xml 60

Anything else?

Verification

  • ./gradlew :app:testDebugUnitTest :app:lintDebug :app:assembleDebug — all passing (same as CI)
  • Verified on SM-E055F: Artesanía jewelry screen ("Anillo de plata", "Collar de oro", "Anillo de plata con zafiro", "Estilo de combate: Magia") fully in Spanish; no clipped text, no crashes. Merchant-gated special rings confirmed via aapt2
  • aapt2 dump resources confirms es + es-rES ("Anillo de Riqueza", "Anillo de Videntes", "Gólem de Roca")
  • XML/parity/order/placeholders clean; git diff --check clean

How this was produced

Translated by muse-spark-1.3-contributor (provider opencode-go) running in the gentle-pi harness (v3.7.0), and reviewed string by string by a native Spanish speaker who verified the result on a device build.

@CiaranGruber

Copy link
Copy Markdown
Collaborator

Hi @jmmartinell, thanks for the translations, they are appreciated.

Just with the pull requests, would you be able to keep them ideally to a single PR rather than multiple small PRs? The reason for this is that having it in multiple small PRs tends to cause a lot of merge conflicts that then need to be resolved which adds a lot more work - having it in a single PR should significantly reduce these merge conflicts (or reduce them down to nothing when the conflicts are due to the PRs themselves conflicting with one another. If you have additional translations, you should be able to work off the same branch and GitHub will update the PR with the new commits

@CiaranGruber CiaranGruber mentioned this pull request Sep 25, 2026
1 task
@CiaranGruber
CiaranGruber merged commit b6d7f61 into tristinbaker:main Sep 25, 2026
1 check passed
@jmmartinell
jmmartinell deleted the translate-es-items-resto2-20260925002138 branch September 25, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants