test: check request cancellation before backend dispatch - #8953
Open
pskiran1 wants to merge 21 commits into
Open
test: check request cancellation before backend dispatch#8953pskiran1 wants to merge 21 commits into
pskiran1 wants to merge 21 commits into
Conversation
pskiran1
marked this pull request as ready for review
September 3, 2026 13:18
pskiran1
marked this pull request as draft
September 3, 2026 13:20
Greptile SummaryThis PR adds integration coverage for cancelling queued inference requests before backend dispatch and improves cancellation synchronization and diagnostics.
Confidence Score: 5/5The PR appears safe to merge, with no outstanding findings or new actionable defects. The previous findings were manually resolved, and the current implementation uses bounded pending-state polling and logs cancellation only after the core cancellation call completes. The sole change since the previous review is formatting-only and does not alter behavior. Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant gRPC as gRPC handler
participant Limiter as Rate limiter
participant Backend
Client->>gRPC: Submit inference request
gRPC->>Limiter: Queue request
Client->>gRPC: Cancel request
gRPC->>Limiter: Issue core cancellation
Limiter-->>gRPC: Cancelled response
gRPC-->>Client: CANCELLED
Note over Limiter,Backend: Cancelled request is not dispatched
Reviews (13): Last reviewed commit: "Fix pre-commit" | Re-trigger Greptile |
…trt-backend' of https://github.com/triton-inference-server/server into spolisetty/tri-1741-implement-request-cancellation-for-trt-backend
pskiran1
marked this pull request as ready for review
September 7, 2026 08:50
pskiran1
marked this pull request as draft
September 7, 2026 08:50
Signed-off-by: Sai Kiran Polisetty <spolisetty@nvidia.com>
pskiran1
marked this pull request as ready for review
September 8, 2026 05:28
Signed-off-by: Sai Kiran Polisetty <spolisetty@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
This PR expands request-cancellation integration coverage for non-batched identity and TensorRT models.
Adds queued-cancellation and response-cache assertions to the scheduler tests.
Creates rate-limited TensorRT and resource-holder models for backend-dispatch coverage.
Adds TensorRT cancellation, normal queued execution, and unaffected-request cases.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/core#522
triton-inference-server/tensorrt_backend#127
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)