fix(crypto): resolve the invalid witness #6368
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Federico2014
changed the title
bladehan1
approved these changes
Jul 2, 2025
3for
approved these changes
Jul 3, 2025
317787106
reviewed
Jul 3, 2025
framework/src/main/java/org/tron/core/metrics/node/NodeMetricManager.java
Show resolved
Hide resolved
…_witness # Conflicts: # framework/src/test/java/org/tron/core/zksnark/ShieldedReceiveTest.java
barbatos2011
approved these changes
Jul 9, 2025
kuny0707
approved these changes
Jul 11, 2025
lxcmyf
reviewed
Jul 16, 2025
| @@ -72,6 +72,8 @@ public void start() { | |||
| if (null == witnessCapsule) { | |||
| logger.warn("Witness {} is not in witnessStore.", Hex.toHexString(witnessAddress)); | |||
| } | |||
| // In multi-signature mode, the address derived from the private key may differ from | |||
| // witnessAddress. | |||
| Miner miner = param.new Miner(privateKey, ByteString.copyFrom(privateKeyAddress), | |||
| ByteString.copyFrom(witnessAddress)); | |||
| miners.add(miner); | |||
There was a problem hiding this comment.
How to handle it when privateKeys.size() == 0 ?
There was a problem hiding this comment.
If the privateKeys.size() == 0, miners will be empty, DposTask will not execute. So we need not to handle it.
if (!dposService.isEnable() || ObjectUtils.isEmpty(dposService.getMiners())) {
return;
}
0b5646b to
3b6fe6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #6281