Skip to content

feat: add NaboxWallet support#98

Open
04-26 wants to merge 3 commits into
tronweb3:mainfrom
04-26:feat/naboxwallet
Open

feat: add NaboxWallet support#98
04-26 wants to merge 3 commits into
tronweb3:mainfrom
04-26:feat/naboxwallet

Conversation

@04-26
Copy link
Copy Markdown

@04-26 04-26 commented Sep 17, 2025

Please support NaboxWallet Adapter, the test has passed.

image

@zorro11639
Copy link
Copy Markdown
Contributor

Thank you for your work, and thanks to NaboxWallet for supporting TRON. To ensure the authority of WalletAdapter and protect user security, please apply to be included in the official wallet list. 


For better testing, we would appreciate your reply to the following questions at your convenience.
What platform does the wallet support ?

  • Android app
  • iOS app
  • Extension

What functions does the wallet support ?

  • signMessage
  • signTransaction
  • multiSign
  • Deeplink to open Wallet App
  • accountsChanged

@04-26
Copy link
Copy Markdown
Author

04-26 commented Sep 17, 2025

For better testing, we would appreciate your reply to the following questions at your convenience. What platform does the wallet support ?

  • Android app
  • iOS app
  • Extension

What functions does the wallet support ?

  • signMessage
  • signTransaction
  • multiSign
  • Deeplink to open Wallet App
  • accountsChanged

Pls check.

@zorro11639
Copy link
Copy Markdown
Contributor

Thank you very much, we will test these features. Once these features are verified to work correctly and the wallet is officially certified, we will publish the npm package.

@04-26
Copy link
Copy Markdown
Author

04-26 commented Sep 18, 2025

Thank you very much, we will test these features. Once these features are verified to work correctly and the wallet is officially certified, we will publish the npm package.

Do we need to apply for official wallet certification ourselves?

@zorro11639
Copy link
Copy Markdown
Contributor

Thank you very much, we will test these features. Once these features are verified to work correctly and the wallet is officially certified, we will publish the npm package.

Do we need to apply for official wallet certification ourselves?

The official wallet list is here. As we are not fully aware of the specific details of the wallet, the application should be submitted by the wallet team.

@04-26
Copy link
Copy Markdown
Author

04-26 commented Sep 25, 2025

Thank you very much, we will test these features. Once these features are verified to work correctly and the wallet is officially certified, we will publish the npm package.

Do we need to apply for official wallet certification ourselves?

The official wallet list is here. As we are not fully aware of the specific details of the wallet, the application should be submitted by the wallet team.

Hi, the official wallet certification has passed, please check.

@zorro11639
Copy link
Copy Markdown
Contributor

Thanks a lot. We will conduct the test.

@zorro11639
Copy link
Copy Markdown
Contributor

@04-26 Hi, I imported a mnemonic pharse but the generated address on TRON is not same as in other wallet. Commonly the default derivation path should be m/44'/195'/0'/0'/0'. And when adding a wallet, the default component that increases should be index.
Could you help to check it ?

@zorro11639
Copy link
Copy Markdown
Contributor

There are some conflicts that must be resolved. Could you please rebase the latest main branch ?

@04-26
Copy link
Copy Markdown
Author

04-26 commented Sep 25, 2025

@04-26 Hi, I imported a mnemonic pharse but the generated address on TRON is not same as in other wallet. Commonly the default derivation path should be m/44'/195'/0'/0'/0'. And when adding a wallet, the default component that increases should be index. Could you help to check it ?

thanks, I will check.

@04-26
Copy link
Copy Markdown
Author

04-26 commented Sep 26, 2025

@04-26 Hi, I imported a mnemonic pharse but the generated address on TRON is not same as in other wallet. Commonly the default derivation path should be m/44'/195'/0'/0'/0'. And when adding a wallet, the default component that increases should be index. Could you help to check it ?

Hi, I checked the path, the default is "m/44'/60'/0'/0/0". I will modify the default path of TRON, but it will take the next version. If other methods are OK, can you merge the code first? I will also resolve the conflict first.

@zorro11639
Copy link
Copy Markdown
Contributor

zorro11639 commented Sep 26, 2025

To ensure the authority of the TronWalletAdapter and prevent misunderstandings among users,we will test NaboxAdapter together with other adapters, and only merge the code and release it after confirming there are no issues.

@04-26
Copy link
Copy Markdown
Author

04-26 commented Sep 26, 2025

To ensure the authority of the TronWalletAdapter and prevent misunderstandings among users,we will test NaboxAdapter together with other adapters, and only merge the code and release it after confirming there are no issues.

In other words, do we need to wait until the NaboxWallet path is modified, updated, and tested before merging the code and releasing it?

@zorro11639
Copy link
Copy Markdown
Contributor

Exactly. We’ll merge and release after the derivation path is updated and tested. Thanks for confirming.

319344799@qq.com added 2 commits November 3, 2025 11:38
# Conflicts:
#	README.md
#	demos/dev-demo/src/components/WalletProvider.tsx
#	packages/adapters/adapters/README.md
#	packages/adapters/adapters/package.json
#	packages/adapters/adapters/tsconfig.all.json
#	pnpm-lock.yaml
#	tsconfig.all.json
@04-26
Copy link
Copy Markdown
Author

04-26 commented Nov 7, 2025

Exactly. We’ll merge and release after the derivation path is updated and tested. Thanks for confirming.

NaboxWallet has released a new version, please check it again, thanks.

@zorro11639 zorro11639 moved this from Todo to In Progress in TronWallet Adapter Nov 18, 2025
@zorro11639
Copy link
Copy Markdown
Contributor

Thanks a lot. We will merge it soon and conduct the test work. After testing we will release the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants