add support for Gerrit 2.15 #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 21, 2018 11:55
According to [1], Python 2.x is legacy and Python 2.7 is the end-of-life release. Minor changes are needed to use Python 3.x, this commit implements those changes. [1] https://wiki.python.org/moin/Python2orPython3#What_are_the_differences.3F
The --is-draft parameter is no longer passed by Gerrit to the patchset-created script [1]. Remove it and adjust the issue's added comment and in review status update accordingly. [1] https://gerrit.googlesource.com/plugins/hooks/+/master/src/main/resources/Documentation/hooks.md
Gerrit now passes the change owner and change owner username as well as a kind parameter for the patchset. It also adds the uploader's username [1]. Add those options to the command line parsing to future-proof the script. [1] https://gerrit.googlesource.com/plugins/hooks/+/master/src/main/resources/Documentation/hooks.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset updates the script to allow usage of the new arguments passed in by Gerrit. Furthermore, the script is ported to Python 3.