Fix/hyperpose variable arg#152
Merged
Merged
Conversation
Contributor
Author
|
@patham9 any review? |
patham9
approved these changes
Apr 2, 2026
Collaborator
patham9
left a comment
There was a problem hiding this comment.
@ermijeremy Well-done, and perfectly executed, thank you so much!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
hyperposeto support variable/computed list arguments in translatorDescription
Problem
hyperposeworked only when its argument was a literal list at translation time, e.g.:but failed for variable/computed lists, e.g.:
Root cause
In
translator.pl, thehyperposebranch directly calledbuild_hyperpose_branches(L, ...), which assumesLis already a concrete list during translation.Fix
Updated
translate_exprforHV == hyperposeto use two paths:Lis a nonvar list, keep existing branch compilation behavior.Lfirst, then executehyperpose_runtime(LV, Out)for variable/computed list arguments.Added helper:
For expressions like
(let $xs (...) (hyperpose $xs)), the runtime helper iterates/evaluates each element concurrently, preservinghyperposesemantics.Validation
!(test (collapse (hyperpose (x y z))) (x y z))passes.!(test (collapse (let $x (x y z) (hyperpose $x))) (x y z))now passes.