Skip to content

Add result-based assertion helpers and complete he_assert todo tests#163

Merged
patham9 merged 2 commits into
trueagi-io:mainfrom
AlexKalll:todo/add-equalTo-assertion
May 9, 2026
Merged

Add result-based assertion helpers and complete he_assert todo tests#163
patham9 merged 2 commits into
trueagi-io:mainfrom
AlexKalll:todo/add-equalTo-assertion

Conversation

@AlexKalll
Copy link
Copy Markdown
Contributor

This PR adds the missing result-based assertion helpers (assertEqualToResult & assertAlphaEqualToResult ) and activates the TODO tests that depend on them.

Updates

  1. Added assertEqualToResult in lib_he.metta, which uses assertEqual.
  2. Added assertAlphaEqualToResult in lib_he.metta, which uses assertAlphaEqual.
  3. Replaced commented TODO lines with active tests in he_assert.metta.

Validation

  • Ran: time sh run.sh he_assert.metta
  • Result: all tests passed

Copy link
Copy Markdown
Collaborator

@patham9 patham9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@patham9 patham9 merged commit ca3b4d8 into trueagi-io:main May 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants