Bail early on bad token #482
Conversation
|
Merging to
|
gnalh
force-pushed
the
gabe/trunk-14336-bail-early-on-non-retry-errors-from-the-api
branch
from
58847ba to
9ff3222
Compare
|
|
||
| // Verify only the quarantine config request was made | ||
| let requests = state.requests.lock().unwrap().clone(); | ||
| assert_eq!(requests.len(), 0); |
There was a problem hiding this comment.
Why are we expecting 0 requests instead of 1?
There was a problem hiding this comment.
The request didn't go through because it raises an error above.
There was a problem hiding this comment.
But how do you get the error from the state server without sending a request to it? Doesn't the cli have to send a request to get the 404 from the server?
There was a problem hiding this comment.
The logic in the mock_server is such that if there's an error during the request then this will not be populated if there is an error. I agree it's confusing given the name and we should move towards it always being populated.
gnalh
force-pushed
the
gabe/trunk-14336-bail-early-on-non-retry-errors-from-the-api
branch
from
0bd87fb to
6452ff6
Compare
|
Closing this since it isn't as easy as we'd hoped |
We shouldn't keep trying our endpoints if we've already detected an issue with the token / org combination.