[wip] Add missing code coverage #650
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
- Coverage 74.09% 69.54% -4.55%
==========================================
Files 64 60 -4
Lines 14026 12128 -1898
==========================================
- Hits 10393 8435 -1958
- Misses 3633 3693 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gnalh
commented
Jun 9, 2025
context-py/src/lib.rs
Outdated
| @@ -61,7 +61,7 @@ fn branch_class_to_string(branch_class: env::parser::BranchClass) -> String { | |||
| #[gen_stub_pyfunction] | |||
| #[pyfunction] | |||
| fn ci_platform_to_string(ci_platform: env::parser::CIPlatform) -> String { | |||
| ci_platform.to_string() | |||
| ci_platform.to_string().into() | |||
There was a problem hiding this comment.
Was seeing this error when running the code coverage report
error[E0308]: mismatched types
--> context-py/src/lib.rs:64:5
|
63 | fn ci_platform_to_string(ci_platform: env::parser::CIPlatform) -> String {
| ------ expected `String` because of return type
64 | ci_platform.to_string()
| ^^^^^^^^^^^^^^^^^^^^^^^ expected `String`, found `&str`
|
help: call `Into::into` on this expression to convert `&str` into `String`
|
64 | ci_platform.to_string().into()
| +++++++
gnalh
commented
Jun 9, 2025
| cargo llvm-cov --no-report --doc | ||
| cargo llvm-cov report --doctests --lcov --output-path lcov.info | ||
|
|
||
| - name: Run tests |
There was a problem hiding this comment.
Turns out this is redundant and not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.