refactor: remove three later PURL processing in more places #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the three PURL layers (base, version, qualifier) for building result PURLs, we only use the `purl` field from the qualified result, and evaluate the rest inline. The allows us to reduce load on the database even more.
mrizzi
approved these changes
Mar 14, 2025
dejanb
approved these changes
Mar 14, 2025
dejanb
reviewed
Mar 14, 2025
| @@ -356,11 +349,7 @@ impl SbomAdvisory { | |||
| id: each.sbom_package.node_id.clone(), | |||
There was a problem hiding this comment.
I think we can optimize this further by not returning the whole package info as I don't think it's useful in this context. That would also allow us to join less tables in the relevant_advisory_info query. But we can do that in a separate PR
There was a problem hiding this comment.
Yea, I agree, there's more potential. But I didn't want to go all crazy right before a release. 😉
|
Either I did it wrong, or it doesn't impact performance:
|
|
Ah, I did it wrong indeed. 🤦 Will re-run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the three PURL layers (base, version, qualifier) for building result PURLs, we only use the
purlfield from the qualified result, and evaluate the rest inline.The allows us to reduce load on the database even more. I'll run a scale-test next.