Update jscad-electronics to 0.0.155 - #982
Draft
addibble wants to merge 1 commit into
Draft
Conversation
Picks up jscad-electronics#333, which mounts through-hole pin headers on top of the board instead of beneath it. Every `<pinheader>` renders through this package — core resolves them to `pinrow…` footprint strings — so until this bump the viewer draws them hanging under the PCB with 2mm of pin poking up through the holes. Also 32 part bodies that previously rendered as nothing: the SOT and SC-70 families, TO-252/263, electrolytics, potentiometers, SMD switches, BGA. A footprint with no body is not a cosmetic gap in a viewer that measures things — it has no height at all. No test outcome changes: 41 pass and 5 fail both before and after, and the five are the same five (faux-board z defaults, and three 3d-view-to-svg snapshots). They fail on main today, unrelated to this dependency. Noticed while checking that: `bun test` fails on main here, 5 of 46 — the faux-board z defaults and three 3d-view-to-svg snapshots — and no workflow in this repo runs `bun test`, so CI has never seen them. Untouched by this change and left alone; flagging because a suite that nothing runs stops being true quite quickly.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up jscad-electronics#333, which mounts through-hole pin headers on top
of the board instead of beneath it. Every
<pinheader>renders through thispackage — core resolves them to
pinrow…footprint strings — so until thisbump the viewer draws them hanging under the PCB with 2mm of pin poking up
through the holes.
Also 32 part bodies that previously rendered as nothing: the SOT and SC-70
families, TO-252/263, electrolytics, potentiometers, SMD switches, BGA. A
footprint with no body is not a cosmetic gap in a viewer that measures
things — it has no height at all.
No test outcome changes: 41 pass and 5 fail both before and after, and the
five are the same five (faux-board z defaults, and three 3d-view-to-svg
snapshots). They fail on main today, unrelated to this dependency.
Noticed while checking that:
bun testfails on main here, 5 of 46 — thefaux-board z defaults and three 3d-view-to-svg snapshots — and no workflow in
this repo runs
bun test, so CI has never seen them. Untouched by thischange and left alone; flagging because a suite that nothing runs stops being
true quite quickly.