fix(schematic): normalize wrapped arc sweeps - #121
Merged
ShiboSoftwareDev merged 1 commit intoSep 3, 2026
Merged
Conversation
|
@hrithik18k is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
hrithik18k
changed the title
hrithik18k
force-pushed
the
repro/magnetic-core-inductor-rendering
branch
2 times, most recently
from
September 3, 2026 16:17
5a2088a to
9594622
Compare
hrithik18k
force-pushed
the
repro/magnetic-core-inductor-rendering
branch
from
September 3, 2026 17:44
9594622 to
919803b
Compare
ShiboSoftwareDev
approved these changes
Sep 3, 2026
Collaborator
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motive: Render Altium schematic arcs correctly when their angles cross zero degrees.
Altium arcs use a positive counterclockwise sweep, but the SVG renderer treated angles such as 360° to 90° as a −270° sweep instead of 90°, causing magnetic-core inductors and other wrapped arcs to appear distorted. This PR normalizes the arc sweep using a reusable helper, preserves full circles, and updates the relevant tests and snapshots without component-specific hardcoding or hacks.