fix(schematic): render electrical pin directions - #128
Open
KrishnaX12 wants to merge 1 commit into
Open
Conversation
|
@KrishnaX12 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
KrishnaX12
force-pushed
the
fix/schematic-component-display-mode
branch
from
September 3, 2026 19:04
08f12b6 to
a05a748
Compare
KrishnaX12
force-pushed
the
fix/schematic-component-display-mode
branch
6 times, most recently
from
September 3, 2026 20:06
a3c2888 to
23ebea5
Compare
KrishnaX12
force-pushed
the
fix/schematic-component-display-mode
branch
4 times, most recently
from
September 4, 2026 12:21
6b27e1d to
55e45fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showPinDirections: false.Root Cause
The SVG serializer parsed
ELECTRICALbut did not use it when rendering schematic pins. MissingELECTRICALvalues in binary SchDoc records represent Altium default input pins and are handled accordingly.Visual Verification:
altiumts(Fixed) vs Altium 365 Viewer (Reference)altiumts(Fixed)(Sheet 12)
(Sheet 13)
(Sheet 14)
(Sheet 33)
Testing
showPinDirections: falseopt-out using those real records.main.