fix(svg): paint transparent component fills first - #142
Merged
ShiboSoftwareDev merged 1 commit intoSep 6, 2026
Merged
Conversation
|
@KrishnaX12 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
KrishnaX12
force-pushed
the
fix/schematic-transparent-paint-order
branch
from
September 6, 2026 17:23
1471d73 to
dd483c6
Compare
ShiboSoftwareDev
approved these changes
Sep 6, 2026
Video reviewFailed — the review could not finish. Tag the bot in a new comment to retry. The operator can inspect the job logs. Reviewing commit This comment updates as work progresses. Job: 1317762139-issue_comment-5571882600 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
In Altium schematics, component body boxes (such as
RECORD=14rectangles withTRANSPARENT=Tand filled backgroundAREACOLOR) may appear after symbol primitives or pins in the record stream. Previously, these late filled graphics were painted over opaque symbol graphics (like diode triangle fills), obscuring the component symbols.This change separates transparent background fills from opaque foreground graphics, ensuring background boxes are painted first behind symbol graphics while preserving foreground and pin-label paint order.
Visual Comparison: Altium 365 (Reference) vs altium.tscircuit.com
1. RJ45 Connector with Integrated Magnetics (
J9)2. Component Box & Diode Symbol (
D11/D8)Testing
bun test tests/svg/schematic-component-paint-order.test.tsbun test --max-concurrency=1bun run typecheckbun run format:checkbun run build