Render copper polygons with cutout-only regions - #145
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShiboSoftwareDev
force-pushed
the
fix/render-polygons-with-cutouts
branch
from
September 6, 2026 23:24
c04f19d to
965b85d
Compare
Abse2001
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POLYGON_CUTOUTrecordsThis fixes the renderer behavior exposed by the CH582 round-trip fixture: the converted document contains the polygon boundary plus cutout regions, but no poured-copper regions, so the boundary still represents the visible copper area.
Verification
bun test tests/svg/copper-polygon-cutout.test.ts tests/svg/copper-polygon-outline.test.tsbun run typecheckbun run format:checkbun run buildbun testwas also run; tests that do not require the gitignoredreferences/files pass, while reference-backed tests report their missing local fixtures