Skip locationless schematic text - #84
Open
ShiboSoftwareDev wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AltiumTS now renders schematic text records only when the source record contains a location.
Why
Altium stores simulation-model metadata as parameter records without
LOCATION.XorLOCATION.Y. The SVG renderer treated missing coordinates as(0, 0), so unrelated strings such as SPICE netlist templates were all drawn on top of each other along the lower-left edge of the sheet.Locationless records do not have drawable placement information. Skipping them preserves every normally positioned label while removing the invented pile of simulation text.
Testing
bun test tests/svg/schematic-locationless-text.test.ts tests/svg/sample-schematic-sheet.test.ts --max-concurrency=1bun run format:checkbun run typecheckbun run build