Skip unplaced schematic parameter text - #85
Open
ShiboSoftwareDev wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Altium component libraries store netlist and simulation metadata as parameter records without drawing coordinates. The SVG renderer treated missing coordinates as zero, so many internal strings were painted on top of each other at the sheet edge.\n\nWhat changed:\n- Require schematic text records to have an explicit placement before rendering them.\n- Keep placed parameters working, including the existing hidden-text option.\n- Add one focused SVG snapshot repro with both an unplaced simulation parameter and a placed value.\n- Update the existing Hyperpolyglot schematic snapshot, which now removes 17 overlapping model/simulation strings from the bottom edge.\n\nThe same fix was checked against the real HERON PAY-SSM SchDoc: INITIAL VOLTAGE and INITIAL CURRENT no longer appear in the SVG and the dark lower-edge line is gone.\n\nValidation:\n- Focused repro, Hyperpolyglot, SimpleFOC Mini, SimpleFOC Shield, and Elk Pi schematic tests pass.\n- Typecheck, format check, lint, and build pass.\n- Changed SVG snapshots pass XML validation.\n- The full local suite reaches the separately downloaded TI tests; those remain unavailable locally because the TI reference package is not present.