add ftype: mechanical_spst_switch #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abhijitxy
commented
Aug 19, 2024
abhijitxy
commented
- Add ftype: "mechanical_spst_switch" to tscircuit/soup
seveibar
requested changes
Aug 19, 2024
src/source/source_simple_switch.ts
Outdated
| import { z } from "zod" | ||
|
|
||
| export const source_simple_switch = source_component_base.extend({ | ||
| ftype: z.literal("mechanical_spst_switch"), |
There was a problem hiding this comment.
Can you make this an enum because we'll add more in the future
src/source/source_simple_switch.ts
Outdated
| import { source_component_base } from "src/source/base/source_component_base" | ||
| import { z } from "zod" | ||
|
|
||
| export const source_simple_switch = source_component_base.extend({ |
There was a problem hiding this comment.
Can we rename this to just source_switch
seveibar
approved these changes
Aug 19, 2024
seveibar
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.