Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to doc generation #97

Merged
merged 2 commits into from
Dec 15, 2024
Merged

fix to doc generation #97

merged 2 commits into from
Dec 15, 2024

Conversation

ShiboSoftwareDev
Copy link
Contributor

The script was searching for interfaces and not types
I also fixed two other issues:

  • the source docs were not generated on windows since the regex was using unix style slashes when searching for 'source'
  • the toc was not updating because of a missing '' closing comment tag

/claim #95
/closed #95

@algora-pbc algora-pbc bot mentioned this pull request Dec 14, 2024
Closed
@ShiboSoftwareDev
Copy link
Contributor Author

looks like some code is missing, I need to revise this

seveibar
seveibar reviewed Dec 14, 2024
View reviewed changes
README.md Outdated
export type PcbComponentInput = z.input<typeof pcb_component>
t

export type PcbComponentInput = z.input<typeof pcb_component>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we ignore the zod types in the docs

seveibar
seveibar reviewed Dec 14, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fix the zod types showing up but otherwise looking good!

@ShiboSoftwareDev
Copy link
Contributor Author

@seveibar

seveibar
seveibar approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it /tip $10

@seveibar seveibar merged commit afe6855 into tscircuit:main Dec 15, 2024
3 checks passed
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Dec 15, 2024

🎉🎈 @ShiboSoftwareDev has been awarded $10! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PcbPlatedHole is missing from README
2 participants
@ShiboSoftwareDev @seveibar