fix(schematic): Omit VCC and GND from net connections to render as net labels instead #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
When i am running for |
seveibar
requested changes
Nov 16, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
not the correct fix, lots of regressions from the snapshots
nailoo
reviewed
Nov 16, 2025
Comment on lines
+286
to
293
| // Estimate net label width using same heuristic as computeSchematicNetLabelCenter | ||
| // Default font_size is 0.18 and charWidth = 0.1 * (font_size / 0.18) | ||
| const fontSize = 0.18 | ||
| const charWidth = 0.1 * (fontSize / 0.18) | ||
| const netLabelWidth = Number( | ||
| (String(userNetId).length * charWidth).toFixed(2), | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
Reformat it. try to run bun run format
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: tscircuit/schematic-trace-solver#79
/claim tscircuit/schematic-trace-solver#79
Modifications to the createSchematicTraceSolverInputProblem function now selectively filter VCC and GND sourceNet entries, preventing their inclusion in the netConnections array passed to the solver. This code change alters the trace solver's input problem, effectively disabling autorouting for global power and ground nets