Fix perpetual loading issue in docs components #168
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add timeout fallbacks to TscircuitIframe component (10s + 5s) - Add error handling and user-friendly error messages for iframe failures - Add timeout fallbacks to CDN URL hooks (5s with fallback URLs) - Replace null returns with loading indicators in CDN-dependent components - Ensure all loading states have recovery mechanisms Fixes tscircuit#167
|
@RaghavArora14 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@seveibar please review, vercel has deployed the preview |
|
Issue already solved, this solution is incorrect |
|
The reason i dont like this solution is it didnt find the underlying issue whivh was a specific bad image, instead it just made it so the page errored out after timeout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/Fixes #167
/claim #167