Improve HighDensitySolverA02 convergence for repro02/03/04 and assert solved state - #35
Draft
seveibar wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
repro02,repro03andrepro04sometimes timed out or finished withsolver.solved === falsedue to heavy rip-up churn and searches running out of iterations.Description
connRips+searchIterations) by checkingconnRips >= 24andsearchIterationsthresholds and callingtryLastConnectionFallbackwith a new parameter to indicate emergency mode viaforceDeferredRipup(changes inHighDensitySolverA02).unsolvedSegs.length <= 4or(ripCount[connId] ?? 0) >= 8and enabling fallback to request deferred rip-up when forced.tryLastConnectionFallbackto acceptforceDeferredRipupand to use that when decidingdeferRipupfor committed fallback routes.tests/repros/repro02,repro03,repro04) to assertexpect(solver.solved).toBeTrue()andexpect(solver.failed).toBeFalse()alongside the SVG snapshot checks, and refresh the SVG snapshots for the adjusted outputs.Testing
BUN_UPDATE_SNAPSHOTS=1 bun test tests/repros/repro02/repro02.test.ts tests/repros/repro03/repro03.test.ts tests/repros/repro04/repro04.test.tsand all three tests passed and snapshots were written.bun test tests/repros/repro02/repro02.test.ts tests/repros/repro03/repro03.test.ts tests/repros/repro04/repro04.test.tsand all three tests passed.bun run format(succeeded) andbunx tsc --noEmitwhich failed in this environment due to a missing external dataset module (@tscircuit/hypergraph/datasets/jumper-graph-solver/dataset02.json).Codex Task