Improve A02 final acceptance and enforce solved checks for repro02/03/04 - #36
Draft
seveibar wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
HighDensitySolverA02from hard-failing near iteration limits and give it additional recovery passes so repro02/repro03/repro04 finish assolvedrather than timing out or failing.Description
tryFinalAcceptance()to run extra search budget, per-connection fallback attempts, and deferred fallback sweeps via a newtryBruteforceFallbackSweeps()helper.allConnectionSegsto store the full set of connection segments and initializeunsolvedSegsfrom it for safe restarts and brute-force sweeps.unsolvedSegsand clear temporary state instead of immediately settingfailed.forceImmediateRipupflag totryLastConnectionFallback()to control deferred ripup behavior during forced fallback attempts.tests/repros/repro02/repro02.test.ts,tests/repros/repro03/repro03.test.ts, andtests/repros/repro04/repro04.test.tsto assertsolver.solved === trueandsolver.failed === falseand refreshed therepro02SVG snapshot attests/repros/repro02/__snapshots__/repro02.snap.svg.Testing
BUN_UPDATE_SNAPSHOTS=1 bun test tests/repros/repro02/repro02.test.ts tests/repros/repro03/repro03.test.ts tests/repros/repro04/repro04.test.tsand then normal run; all three repro tests passed (snapshots updated where required).bun test ...) for the three repro files.bun run formatwhich succeeded.bunx tsc --noEmitwhich failed due to unrelated missing dataset module declarations in existing repo scripts/tests (pre-existing issue not introduced by this change).Codex Task