fix: let A01 finish while routing progresses - #88
Open
ShiboSoftwareDev wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #87, which adds the unchanged
srj24sample 1 reproduction.Problem
A01 was making progress, but four generic bookkeeping errors prevented this dense region from completing:
Fix
There are no dataset-specific IDs, topology exceptions, or sample-specific parameter values.
Result
The exact same fixture and snapshot test from #87 changes naturally from failed: 31/46 to solved: 46/46, 0 geometry violations.
Each panel is the same physical region on one PCB layer. Colored dots are terminals, colored paths are traces on that layer, and gray circles are through-vias.
Verification
The end-to-end
srj24benchmark belongs in the consumingtscircuit-autorouterPR after this package fix is released; it will be run in GitHub Actions rather than as a local full-dataset benchmark.