Add visual snapshot for A03 terminal layer repro - #90
Open
seveibar wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- add the reduced A03 node extracted from the Pipeline9 Arduino reroute failure\n- render the input ports on the left and the original, unfixed A03 output on the right\n- draw the node boundary in both panels and snapshot the comparison via visualize() and toMatchSvgSnapshot\n- intentionally preserve the current output so the fix in #89 has a clear visual before/after diff\n\n## What to look for\n\nThe left panel makes the input geometry explicit: 8 of 18 ports lie on the node boundary and 10 are interior. Interior endpoints are valid regional-repair inputs; A03 maps arbitrary endpoint coordinates into its grid.\n\nThe defect is visible in the right panel: the route from the red endpoint near the middle-left travels on the blue layer, then changes to the red layer laterally at the endpoint. There is no gray via marker at that transition. The gray via farther to the right is the earlier valid layer change.\n\n## Test plan\n\n- BUN_UPDATE_SNAPSHOTS=1 bun test --timeout 9999999\n- bun run build\n- bunx tsc --noEmit\n- bun run format:check\n- git diff --check