Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add ExampleWrapper component with code toggle functionality #91

Merged
merged 6 commits into from
Nov 23, 2024

Conversation

AnasSarkiz
Copy link
Member

/claim #89
#89

Copy link

algora-pbc bot commented Nov 8, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@AnasSarkiz AnasSarkiz requested a review from seveibar November 8, 2024 19:55
lib/components/Example-wrapper.tsx Outdated Show resolved Hide resolved
@AnasSarkiz
Copy link
Member Author

@seveibar
I've implemented a Vite plugin middleware to serve code examples from the "examples" directory check the last commit

Screenshot 2024-11-22 at 9 37 48 PM Screenshot 2024-11-22 at 9 37 56 PM

@AnasSarkiz AnasSarkiz requested a review from seveibar November 22, 2024 19:44
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is pretty good and basically ready, but I think you removed some important stuff from the vite config and ideally nobody has to type the filename each time in the example wrapper (using bun, I think we can use import.meta.path, please give that a try and let me know)

@AnasSarkiz AnasSarkiz requested a review from seveibar November 22, 2024 23:20
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use import meta path so users dont have to remember to change file names

@AnasSarkiz AnasSarkiz requested a review from seveibar November 23, 2024 20:18
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@AnasSarkiz AnasSarkiz merged commit 90bac7b into tscircuit:main Nov 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants