Lay out decoupling capacitor partitions as uniform banks#120
Open
forgehk wants to merge 1 commit into
Open
Conversation
|
@forgehk is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @forgehk , thanks so much for your contribution. Unfortunately, we’ve closed the bounty program, but we really appreciate your effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Decoupling-cap partitions (already produced by ChipPartitionsSolver with
partitionType: "decoupling_caps") now skip PackSolver2 and get adatasheet-style bank layout in SingleInnerPartitionPackingSolver:
(derived from the partition's
isPositiveVoltageSource/isGroundnetflags; a flipped-wired cap is rotated 180)
decouplingCapsGap, VCC pins aligned into a straight railPartitionPackingSolver is unchanged; the bank keeps its real net ids so the
existing network-distance packing pulls it next to the main chip.
Evidence: SVG snapshot tests using graphics-debug/matcher + bun-match-svg
(both already in node_modules as peers of graphics-debug; the bunfig preload
for them was already in the repo, commented out). One unit-level snapshot of
the bank and one full-pipeline snapshot on the LayoutPipelineSolver06 fixture
(RP2040-style chip with 6+2 decoupling caps).
Before (caps in scrambled order: C15 C12 C14 C8 C13 C19):
After (deterministic bank C8 C12 C13 C14 C15 C19, uniform pitch, straight rail):
bun test: 22 pass, 1 skip (pre-existing), 0 fail. No dependency or lockfilechanges.
/claim #15