Skip to content

Fix port-only net label placement solver and update snapshots #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix port-only net label placement solver and update snapshots #42

wants to merge 2 commits into from

Conversation

seveibar
Copy link
Contributor

@seveibar seveibar commented Sep 5, 2025

Summary

  • fix SingleNetLabelPlacementSolver port-only pin handling by computing chip bounds and offsetting label outside the chip
  • add detailed logging for orientation, distance and collisions
  • restore failing regression test and refresh example snapshots

Testing

  • bun test tests/solvers/NetLabelPlacementSolver/SingleNetLabelPlacementSolver/SingleNetLabelPlacementSolver01.test.ts
  • BUN_UPDATE_SNAPSHOTS=1 bun test tests/examples
  • bun test

https://chatgpt.com/codex/tasks/task_b_68ba8296c048832eb50a81c8cf4c146d

@vercel Vercel
Copy link

vercel bot commented Sep 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
schematic-trace-solver Ready Ready Preview Comment Sep 5, 2025 7:54pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seveibar