fix: restore same-net schematic trace hover grouping#212
Open
AlissonBecker1 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AlissonBecker1
force-pushed
the
fix-trace-hover-connectivity-keys
branch
from
May 22, 2026 19:09
e50dffc to
3b80bb0
Compare
AlissonBecker1
force-pushed
the
fix-trace-hover-connectivity-keys
branch
from
May 22, 2026 20:16
3b80bb0 to
fa0275e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subcircuit_connectivity_map_keyto schematic traces before SVG conversion so the existing circuit-to-svg same-net hover CSS can applyFixes tscircuit/tscircuit#1130
Verification
bun test tests/connected-schematic-trace-groups.test.tsxbunx tsc --noEmitbun run buildbunx biome check lib/components/SchematicViewer.tsx lib/utils/getConnectedSchematicTraceGroups.ts tests/connected-schematic-trace-groups.test.tsx examples/example21-connected-trace-hover.fixture.tsxgit diff --check